Microsoft/vscode

Cannot use arrow keys to go to toggle icon in notebook find widget

Open

#207,765 opened on Mar 14, 2024

View on GitHub
 (1 comment) (0 reactions) (1 assignee)TypeScript (10,221 forks)batch import
accessibilitybughelp wantednotebook-find

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

  1. Open a notebook and CTRL+F
  2. Use tab on the find action buttons- notice that this allows you to navigate to all of the different buttons.
  3. Use right/left arrow on the find action buttons- notice that this only loops between the first three.

I think the problem is here: https://github.com/microsoft/vscode/blob/a984153d6a98fba04f0a39a5ab9918c7b6e47511/src/vs/base/browser/ui/findinput/findInput.ts#L170-L194

The arrow key navigation is fixed at the findInput level, and we aren't adding to it, even when adding the funnel icon.

In this screencap, I accidentally press the down key-- that's not part of the demo 😅 https://github.com/microsoft/vscode/assets/31675041/9949cd63-a57c-42e3-9fd8-0d03de6f44cb

Contributor guide

Research direction
Examine the arrow key navigation logic in the findInput.ts file, specifically around line 170-194, and understand how the toggle icon is added to see why it's not included in the navigation loop.
Tech stack
typescript
Domain
frontendaccessibility
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65