Microsoft/vscode

parentTerminal doesn't always work

Open

#205,254 opened on Feb 15, 2024

View on GitHub
 (4 comments) (2 reactions) (1 assignee)TypeScript (10,221 forks)batch import
bughelp wantedterminal-tabs

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: Version: 1.86.1 (system setup) Commit: 31c37ee8f63491495ac49e43b8544550fbae4533 Date: 2024-02-07T09:08:20.941Z Electron: 27.2.3 ElectronBuildId: 26495564 Chromium: 118.0.5993.159 Node.js: 18.17.1 V8: 11.8.172.18-electron.0 OS: Windows_NT x64 10.0.19045
  • OS Version: Edition Windows 10 Enterprise Version 22H2 Installed on ‎1/‎15/‎2021 OS build 19045.3930 Experience Windows Feature Experience Pack 1000.19053.1000.0

Steps to Reproduce:

This is precisely the same as #131594. The OP-provided code opens terminals that are separate from each other (not split). Ditto for the very similar code quoted in response (the last block). Unfortunately the OP did not follow up but I'm seeing exactly the same issue.

I've definitely seen parentTerminal work when creating two terminals at the same moment and making one the parentTerminal of the other. The option seems to be ignored if the supplied terminal was not created at the same moment, i.e. stored and used in a subsequent call.

Contributor guide

Research direction
Investigate the terminal creation flow to determine why parentTerminal is ignored when the parent terminal was created in a previous call. Focus on how the parent terminal reference is stored and used in subsequent createTerminal calls.
Tech stack
typescript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60