Microsoft/vscode

Git - Support GitHub 2FA

Open

#20,330 opened on Feb 9, 2017

View on GitHub
 (8 comments) (11 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
feature-requestgithelp wanted

Description

  • VSCode Version: 1.9.1
  • OS Version: Ubuntu 14.04, 16.04

Steps to Reproduce:

  1. Make changes to a GitHub repo with two-factor authentication enabled
  2. Push/Sync changes.

Error: Authentication failed on the git remote.

A dialog box appears to enter your git username/password, but there is no subsequent dialog for the two-factor authentication code, and so the process just fails.

The https protocol was used for the git clone on this repo.

Contributor guide

Tech stack
typescript
Domain
authenticationsecurity
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
GitGitHub authenticationVSCode extension development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate VSCode's git extension implementation, specifically how authentication credentials are handled. Look at the git credential helper and the existing login dialog. The issue mentions that there is no prompt for the 2FA code after entering username/password. A solution could involve detecting when a 2FA code is needed and showing an additional prompt. Check the vscode source code in extensions/git for relevant files. Review comments on the issue for any proposed approaches.
Git - Support GitHub 2FA · Microsoft/vscode#20330 | Good First Issue