Microsoft/vscode

Don't prompt for user confirmation when workspace typescript.tsserver.nodePath is set to "node"

Open

#200,923 opened on Dec 15, 2023

View on GitHub
 (5 comments) (1 reaction) (1 assignee)TypeScript (10,221 forks)batch import
feature-requesthelp wantedtypescript

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

We had this awesome feature merged #191019. This will allow our team to get off the custom tsserver implementation we have been using and just use this new setting for everyone.

One issue is that right now when we have a workspace setting for "typescript.tsserver.nodePath" set to "node" (i.e. auto-detect node installation) we get a prompt as shown below

image

I would argue that if the setting is "node" then we are using a user-installed nodejs installation and we don't need to ask for this prompt, because it's user installed and if there are security risks then user has already accepted them with the nodejs installation.

Happy to create a PR to update this if someone can confirm that it's Ok to make this change.

Contributor guide

Research direction
Examine the prompt logic in the TypeScript extension's workspace trust handling, specifically where nodePath is used. Modify the condition to skip the confirmation prompt when nodePath is set to 'node'.
Tech stack
typescript
Domain
desktopdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65