Microsoft/vscode

Don't prompt for user confirmation when workspace typescript.tsserver.nodePath is set to "node"

Open

#200,923 opened on Dec 15, 2023

View on GitHub
 (5 comments) (1 reaction) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
feature-requesthelp wantedtypescript

Description

We had this awesome feature merged #191019. This will allow our team to get off the custom tsserver implementation we have been using and just use this new setting for everyone.

One issue is that right now when we have a workspace setting for "typescript.tsserver.nodePath" set to "node" (i.e. auto-detect node installation) we get a prompt as shown below

image

I would argue that if the setting is "node" then we are using a user-installed nodejs installation and we don't need to ask for this prompt, because it's user installed and if there are security risks then user has already accepted them with the nodejs installation.

Happy to create a PR to update this if someone can confirm that it's Ok to make this change.

Contributor guide

Tech stack
typescriptnodejs
Domain
developer experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptNode.jsVS Code extension development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Investigate where the prompt for users to confirm the workspace typescript.tsserver.nodePath is implemented in the TypeScript extension (likely in extensions/typescript language features). Review the logic that checks if the nodePath is not 'node' and modify it to skip the prompt when the value is exactly 'node'. Reference the linked PR #191019 for context on the feature. After making the change, test the scenario to ensure no regressions.