Microsoft/vscode

Clicking inside editor and releasing the mouse button on a link outside activates the link (web/monaco)

Open

#199,477 opened on Nov 29, 2023

View on GitHub
 (4 comments) (3 reactions) (1 assignee)TypeScript (10,221 forks)batch import
bugeditor-corehelp wanted

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: vscode.dev
  • OS Version: Win10 / Firefox

Steps to Reproduce:

  1. Go to vscode.dev
  2. Open an editor
  3. Click somewhere in the editor (e.g. to select a bunch of text) and keep the mouse button pressed
  4. Move the mouse pointer over something outside the editor, e.g. the "Read the announcement" header
  5. Release the mouse button

Nothing should happen since links/buttons are not supposed to trigger just because you release the mouse button while hovering them. After all, the click did not target that link/button.

FWIW this but is VERY annoying when embedding monaco-editor on a webapp that has a navigation near the editor's left side. When selecting a block of I almost always end up with the cursor on the menu and thus leave the page...

Contributor guide

Research direction
Investigate the mouse event propagation in the Monaco editor. Specifically, check the onMouseDown and onMouseUp handlers in the editor component and see why the mouseup event on a link triggers navigation. Look at the editor's event handling code in src/vs/editor/contrib/links/ or similar.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65