Microsoft/vscode

Terminal profile default discovery isn't working as expected

Open

#195,768 opened on Oct 17, 2023

View on GitHub
 (9 comments) (0 reactions) (1 assignee)TypeScript (10,221 forks)batch import
bughelp wantedlinuxmacosterminal-profiles

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Type: Bug

I have followed the instructions to install fish with homebrew on my Apple Silicon mac. Fish is the default shell in any terminal and added to /etc/shells.

When starting VS Code and opening a terminal, it chooses zsh as my default. Even with forced defaultProfile.osx settings and overridden profiles.osx settings.

Fish is also not shown in the profiles list when selecting another terminal profile.

VS Code version: Code 1.83.1 (f1b07bd25dfad64b0167beb15359ae573aecd2cc, 2023-10-10T23:57:32.750Z) OS version: Darwin arm64 23.0.0 Modes:

Item Value
CPUs Apple M1 (8 x 24)
GPU Status 2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (0.16GB free)
Process Argv
Screen Reader no
VM 0%
Extension Author (truncated) Version
vscode-nginx-conf ahm 0.3.2
github-markdown-preview bie 0.3.0
vscode-fish bma 1.0.37
vscode-intelephense-client bme 1.9.5
vscode-eslint dba 2.4.2
gitlens eam 14.4.0
EditorConfig Edi 0.16.4
prettier-vscode esb 10.1.0
copy-relative-path-and-line-numbers ezf 0.3.1
shell-format fox 7.2.5
copilot Git 1.126.0
copilot-chat Git 0.8.0
todo-tree Gru 0.0.226
prettier-sql-vscode inf 1.6.0
vscode-just kok 2.1.0
restructuredtext lex 189.3.0
rainbow-csv mec 3.7.1
dotenv mik 1.0.1
vscode-filesize mkx 3.1.0
vscode-docker ms- 1.27.0
vscode-language-pack-de MS- 1.83.2023101109
remote-containers ms- 0.315.1
remote-ssh ms- 0.106.5
remote-ssh-edit ms- 0.86.0
remote-explorer ms- 0.4.1
remote-server ms- 1.4.3
vscode-just-php-cs-fixer muu 0.6.2
vscode-sundial muu 3.4.1
gremlins nho 0.26.0
vscode-xml red 0.26.1
vscode-yaml red 1.14.0
git-autoconfig shy 0.0.2
svg-preview Sim 2.8.3
code-spell-checker str 3.0.1
code-spell-checker-german str 2.2.1
vscode-stylelint sty 1.2.4
even-better-toml tam 0.19.2
simple-rst tro 1.5.4
sort-lines Tyr 1.11.0
vscodeintellicode Vis 1.2.30
vscode-swiftformat vkn 1.6.7
vscode-icons vsc 12.5.0
php-debug xde 1.33.0
pretty-ts-errors yoa 0.5.2
save-as-root yy0 1.7.0
markdown-all-in-one yzh 3.5.1

(1 theme extensions excluded)

Contributor guide

Research direction
Investigate the terminal profile detection logic on macOS in the VS Code codebase. Look for where shells are discovered from /etc/shells and how the default is determined. Check if fish is being excluded due to its path or registration. Consider that the user has set fish via homebrew and it is in /etc/shells. The issue suggests that the detection may not be correctly listing all shells from /etc/shells or that the default profile logic is ignoring the system default shell. Start by searching for 'defaultProfile' and 'profiles' handling in the terminal code.
Tech stack
typescript
Domain
frontenddeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65