Microsoft/vscode

Command to open view container doesn't toggle properly

Open

#194,816 opened on Oct 4, 2023

View on GitHub
 (2 comments) (0 reactions) (1 assignee)TypeScript (10,221 forks)batch import
bughelp wantedwebview

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.82
  • OS Version: macOS 13.5

Steps to Reproduce:

  1. contribute a sidebar webview via an extension
  2. trigger workbench.view.extension.my-view-container. this opens the webview
  3. trigger workbench.view.extension.my-view-container again. this should toggle focus back to the editor, but doesn't

https://github.com/microsoft/vscode/blob/4a0e77678c0295b518151ae2d706436bab96ef4f/src/vs/workbench/browser/parts/views/viewsService.ts#L380-L384

I think it's the !layoutService.hasFocus(part) piece that's causing problems. as far as I can tell, document.activeElement is the webview's iframe, but the iframe is not actually a child of the sidebar container, so the hasFocus (I think) always returns false.

Contributor guide

Research direction
Inspect the `hasFocus` function in `viewsService.ts` and determine why it returns false for webview iframes. Check if the iframe is not a child of the sidebar container and trace the focus logic.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70