Microsoft/vscode

Suggestion: make `executeSelectionRangeProvider` respect settings for `editor.smartSelect`

Open

#189,972 opened on Aug 8, 2023

View on GitHub
 (6 comments) (0 reactions) (0 assignees)TypeScript (10,221 forks)batch import
feature-requesthelp wantedsmart-select

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.81.0
  • OS Version: macOS latest

VS Code exposes a command called executeSelectionRangeProvider. This calls provideSelectionRanges with { selectLeadingAndTrailingWhitespace: true, selectSubwords: true }:

https://github.com/microsoft/vscode/blob/42b4bf06704b84b40177f62405497a557a8fd73d/src/vs/editor/contrib/smartSelect/browser/smartSelect.ts#L308-L317

I am wondering whether VS Code should respect the smart select settings exposed under editor.smartSelect (e.g. editor.smartSelect.selectLeadingAndTrailingWhitespace), instead of passing true all of the time.

For context, I'm trying to create an extension that exposes the built-in "smart select" feature through a "quick picker". I've mostly got this working, except it doesn't respect the user's settings for smart select:

https://github.com/microsoft/vscode/assets/921609/52c59aea-9eb2-4439-9520-663daa4513d3

Code: https://github.com/OliverJAsh/vscode-smart-select-picker/blob/8158ebc258649c06a76ba9ec255a0ec315ba6863/src/extension.ts

Contributor guide

Research direction
Look at the smartSelect.ts file linked, find where the settings are defined, and update the call to pass the user's configuration instead of hardcoded values.
Tech stack
typescript
Domain
desktopdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70