Microsoft/vscode

Shell integration breaks prompt when using Fish shell with Tide prompt

Open

#187,185 opened on Jul 6, 2023

View on GitHub
 (6 comments) (12 reactions) (1 assignee)TypeScript (10,221 forks)batch import
bughelp wantedterminal-shell-fish

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

  • VS Code Version: 1.80.0 (Universal)
  • OS Version: macOS 13.4.1 (22F82)

Steps to Reproduce

  1. Set Fish as the default shell for your system.
  2. Install the Tide prompt.
  3. Observe broken prompt and error messages when starting an integrated terminal:
fish: Unknown command: '_tide_item_pwd git'
~/.config/fish/functions/_tide_1_line_prompt.fish (line 4): 
        _tide_item_$item
        ^~~~~~~~~~~~~~~^
in function '_tide_1_line_prompt'
in command substitution
fish: Unknown command: '_tide_item_status cmd_duration context jobs'
~/.config/fish/functions/_tide_1_line_prompt.fish (line 11): 
        _tide_item_$item
        ^~~~~~~~~~~~~~~^
in function '_tide_1_line_prompt'
in command substitution

Screenshots

  • Shell integration disabled, Tide installed

  • Shell integration enabled, Tide not installed

  • Shell integration enabled, Tide installed (prompt broken)

Contributor guide

Research direction
Inspect the shell integration implementation for Fish shell in VS Code's terminal codebase. Identify the injected code that causes conflicts with Tide prompt, specifically the unknown commands like ' tide item pwd git'. Focus on the shell integration scripts in the src/vs/workbench/contrib/terminal/browser/terminalShellIntegration.ts or similar files.
Tech stack
typescript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitBasic shell scripting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70