Microsoft/vscode

Simple browser will be opened multiple times with race

Open

#182,795 opened on May 17, 2023

View on GitHub
 (15 comments) (6 reactions) (1 assignee)TypeScript (10,221 forks)batch import
buggood first issuehelp wantedwebview

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.78.2
  • OS Version: macOS Ventura Version 13.4 Beta

Steps to Reproduce:

  1. Download or package extension yourself in reproduce repo https://github.com/mustard-mh/test/tree/vscode/simple-browser-bug
    • Extension will exec open Simple Browser api when active [1]
    • Active extension with event * [1]
  2. Install extension in your VSCode Desktop
  3. Reload window without Simple Browser tab focus

May-18-2023 02-39-18

Contributor guide

Research direction
Investigate the race condition in the simple browser opening logic. Look at the activation event '*' and how the open Simple Browser API is called multiple times. Trace the event flow and check for missing synchronization.
Tech stack
typescript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScriptVS Code development environment
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50