Microsoft/vscode

Multiple Import Organizers results in corrupted code

Open

#174,295 opened on Feb 13, 2023

View on GitHub
 (25 comments) (34 reactions) (3 assignees)TypeScript (74,848 stars) (10,221 forks)batch import
bugeditor-code-actionshelp wanted

Description

Type: Bug

Use two LSP servers have them both register provider of Organize Import code Action for the same language. When user runs Organize Imports both LSP servers receive the same version of the doc.

  1. The order in which they are run is not configurable.
  2. They don't seem to cascade the content of one into the other.
  3. There is nothing in the UI, or there are no warnings thay say two Import Organizers are registered.
  4. Also, there is no UI to select an import organizer like we can do with formatting.

Repro steps: You will need both isort and ruff extensions. See here: https://github.com/microsoft/vscode-isort/issues/240#issue-1583119337

VS Code version: Code 1.75.1 (441438abd1ac652551dbe4d408dfcec8a499b8bf, 2023-02-08T21:32:34.589Z) OS version: Windows_NT x64 10.0.19045 Modes: Sandboxed: No

Item Value
CPUs Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 x 1498)
GPU Status 2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off
Load (avg) undefined
Memory (System) 31.59GB (15.19GB free)
Process Argv --crash-reporter-id a228f424-c4b5-46af-9d39-ca54fee042cd
Screen Reader no
VM 0%
Extension Author (truncated) Version
tsl-problem-matcher amo 0.6.2
ruff cha 2023.6.0
vscode-eslint dba 2.4.0
gitlens eam 13.2.0
EditorConfig Edi 0.16.4
prettier-vscode esb 9.10.4
copilot Git 1.73.8685
remotehub Git 0.50.0
vscode-docker ms- 1.23.3
isort ms- 2022.8.0
python ms- 2023.3.10411009
vscode-pylance ms- 2023.2.20
remote-containers ms- 0.275.1
remote-ssh ms- 0.96.0
remote-ssh-edit ms- 0.84.0
remote-wsl ms- 0.75.2
vscode-remote-extensionpack ms- 0.23.0
azure-repos ms- 0.26.0
remote-explorer ms- 0.2.0
remote-repositories ms- 0.28.0
remote-server ms- 1.0.0
vsliveshare ms- 1.0.5828
rust-analyzer rus 0.3.1402
code-spell-checker str 2.16.0 
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627cf:30244335
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
vscccc:30610679
pyindex848:30577860
nodejswelcome1:30587005
282f8724:30602487
89544117:30613380
pythonsymbol12cf:30657549
a9j8j154:30646983
vscodedisable:30660115

Contributor guide

Tech stack
typescript
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
familiarity with VS Code's LSP clientbasic knowledge of import organizers
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate how VS Code handles multiple code action providers for organize imports. Look at the relevant code in vscode/src/vs/editor/contrib/codeAction/. The issue references a linked isort issue (#240) and discusses the lack of cascading. Check comments for any maintainer guidance on desired behavior. Propose a mechanism to deduplicate or cascade organize import actions from multiple LSP servers.