Microsoft/vscode

Sets LANG environment variable to wrong value

Open

#173,749 opened on Feb 8, 2023

View on GitHub
 (10 comments) (0 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
bughelp wantedl10n-platformmacosmitigated

Description

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.75.0
  • OS Version: macOS 13.1

Steps to Reproduce:

  1. Launch VS Code.
  2. Open a new integrated terminal.
  3. Enter the command echo $LANG
  4. Observe that the value of the LANG environment variable is wrong; in my case, en_US.UTF-8 even though it is correctly en_GB.UTF-8 elsewhere on my system (for example in the Terminal app).

Note, the same or a very similar issue was reported back in October 2016.

Contributor guide

Tech stack
typescriptshell
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
VS Code terminal architectureEnvironment variable propagation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the terminal process environment variable setup in VS Code. Likely in `src/vs/platform/terminal/node/terminalEnvironment.ts` or similar. Check how `LANG` is inherited from the OS and compare with the system's locale settings. The issue references a previous similar issue #13834, which may have relevant discussion.
Sets LANG environment variable to wrong value · Microsoft/vscode#173749 | Good First Issue