Microsoft/vscode

[mac] Cannot type special characters in terminal

Open

#172,536 opened on Jan 26, 2023

View on GitHub
 (2 comments) (0 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
bughelp wantedmacosterminal-inputupstreamupstream-issue-linked

Description

re https://github.com/microsoft/vscode/issues/168804

  • mac
  • open text editor
  • press and hold e
  • and e is inserted and get a picker for its variants like è, é, etc
  • open a terminal
  • press and hold e
  • 😕 many e are inserted
  • 😕 the variant picker shows but at a "random" location
  • 😕 the variant picker doesn't work, e.g pressing 2 doesn't replace the typed character with that variant

https://user-images.githubusercontent.com/1794099/214871921-a8b6e351-9c33-46e5-8753-8b98a3a1d7d4.mov

Contributor guide

Tech stack
typescriptelectronnodejs
Domain
desktopaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptElectronmacOS input handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the key handling in the terminal component. Look at how the editor handles the press and hold event for character picker (e.g., `editor.action.showAccessibleActions` or similar) and compare to terminal. The linked issue #168804 may contain relevant discussion. Start by examining the terminal's use of xterm.js and its input event handling.