Microsoft/vscode

Support Nushell when resolving the shell environment

Open

#167,335 opened on Nov 27, 2022

View on GitHub
 (17 comments) (11 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
feature-requesthelp wantedworkbench-os-integration

Description

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:

Version: 1.73.1
Commit: 6261075646f055b99068d3688932416f2346dd3b
Date: 2022-11-09T03:54:53.913Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Linux x64 5.19.0-21-generic
Sandboxed: No

OS Version: Ubuntu 22.10 (Lubuntu)

Steps to Reproduce:

  1. Add /home/emilyseville7cfg/.cargo/bin/nu to /etc/shells
  2. Do sudo chsh --shell /home/emilyseville7cfg/.cargo/bin/nu
  3. Relogin to apply changes
  4. Start VS Code
  5. Obtain Unable to resolve your shell environment: Unexpected exit code from spawned shell (code 1, signal null) error

image

Contributor guide

Tech stack
typescriptshell
Domain
backenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
VS Code terminal internalsNushell configurationNode.js child process
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate how VS Code currently resolves shell environment for other shells (e.g., bash, zsh). Look at the terminal extension code in the repository, likely under 'src/vs/platform/terminal/'. Examine the logic that spawns shell processes to determine environment variables. Identify where Nushell fails and propose a fix to support it. Check existing comments for hints about the issue.