Microsoft/vscode

GitHub - for VSCode not properly unlinked until VSCode restart

Open

#164,868 opened on Oct 28, 2022

View on GitHub
 (3 comments) (0 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
buggithubhelp wantedteam-low-hanging

Description

Type: Bug

  1. Link GitHub to VSCode via GitHub for VSCode
  2. Unlink it via Account button (above cogwheel,bottom left) -> Select Github User -> Unlink account
  3. Try to clone a repository. It's still possible to select repositories from the previously linked GitHub account.

Restarting VSCode seems to be the only thing that fully unlinks it, which assumingly can be dangerous.

VS Code version: Code 1.72.2 (d045a5eda657f4d7b676dedbfa7aab8207f8a075, 2022-10-12T22:15:18.074Z) OS version: Windows_NT x64 10.0.19044 Modes: Sandboxed: No

Item Value
CPUs Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz (8 x 3392)
GPU Status 2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: unavailable_offvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off
Load (avg) undefined
Memory (System) 15.94GB (12.35GB free)
Process Argv --crash-reporter-id 037ea8ec-fc9c-4c22-8cbd-1370e713e758
Screen Reader no
VM 67%
Extension Author (truncated) Version
path-intellisense chr 2.8.1
vscode-eslint dba 2.2.6
jquerysnippets don 0.0.1
vscode-html-css ecm 1.13.1
prettier-vscode esb 9.9.0
auto-close-tag for 0.5.14
vscode-language-pack-de MS- 1.72.10120946
python ms- 2022.16.1
vscode-pylance ms- 2022.10.40
jupyter ms- 2022.9.1202862440
jupyter-keymap ms- 1.0.0
jupyter-renderers ms- 1.0.10
vscode-jupyter-cell-tags ms- 0.1.6
vscode-jupyter-slideshow ms- 0.1.5
live-server ms- 0.4.3
autodocstring njp 0.6.1
npm-install ore 0.0.1
vscode-css-peek pra 4.2.0
LiveServer rit 5.7.9
altv-vscode-docs stu 2.0.9
JavaScriptSnippets xab 1.8.0
material-theme zhu 3.15.6
html-css-class-completion Zig 1.20.0

(1 theme extensions excluded)

vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vscaac:30438847
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
pyindex848:30577860
nodejswelcome1:30587005
fc301958:30595537
2e4cg342:30596373

Contributor guide

Tech stack
typescript
Domain
authentication
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The bug is in the GitHub authentication state management in VSCode. The 'unlink' action does not clear the session properly, requiring a restart. Investigate the authentication extension code in `extensions/github authentication/`, focusing on the unlink handler and credential storage. Look at the `onDidChangeSessions` events and ensure the session is removed from the in memory cache. Check the issue comments for any maintainer hints.