Microsoft/vscode

Typing a star in a comment block will lead to an extra end symbol

Open

#156,031 opened on Jul 23, 2022

View on GitHub
 (2 comments) (0 reactions) (2 assignees)TypeScript (74,848 stars) (10,221 forks)batch import
bugeditor-commentshelp wanted

Description

Does this issue occur when all extensions are disabled?: Yes

Steps to Reproduce:

  1. Add a comment block /* */
  2. Type a * after the start symbol (to make it a documentation comment)

https://user-images.githubusercontent.com/14685751/180593895-8754f0bc-4b19-4e19-933b-aaf3ff1af33e.mov

Issue Type: Bug

VS Code version: Code 1.69.2 (3b889b090b5ad5793f524b5d1d39fda662b96a2a, 2022-07-18T16:32:39.000Z) OS version: Darwin arm64 21.6.0 Restricted Mode: No

Item Value
CPUs Apple M1 Pro (8 x 24)
GPU Status 2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled
Load (avg) 3, 2, 2
Memory (System) 16.00GB (0.14GB free)
Process Argv --crash-reporter-id 1b9df062-c1db-4b85-ae3c-942f4b8cff8c
Screen Reader no
VM 0%
Extension Author (truncated) Version
vscode-eslint dba 2.2.6
prettier-vscode esb 9.5.0
vscode-language-pack-zh-hans MS- 1.69.7130921

(1 theme extensions excluded)

vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vscscmwlcmt:30465135
cppdebug:30492333
vscaat:30438848
pylanb8912:30529769
vsclangdf:30486550
c4g48928:30532338

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptVS Code editor code structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The bug occurs when typing `*` after `/*` in a comment block, causing an extra `*/` to be inserted. Investigate the auto closing brackets logic in the VS Code editor. Start by looking at the 'editor.autoClosingBrackets' feature and the comment handling code. Relevant files may be in `src/vs/editor/contrib/comment/` or the TypeScript language service. There are two comments on the issue but no maintainer response; check for any hints. Reproduce the bug locally using the steps provided.