Microsoft/vscode

Searching in terminal with large scrollback and many wrapped lines is slow

Open

#152,548 opened on Jun 18, 2022

View on GitHub
 (4 comments) (2 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
bughelp wantedperfterminal-findupstreamupstream-issue-linked

Description

Might be similar to #147685.

macOS: 12.4 (21F79) code:

Version: 1.68.1 (Universal)
Commit: 30d9c6cd9483b2cc586687151bcbcd635f373630
Date: 2022-06-14T12:52:13.188Z
Electron: 17.4.7
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Darwin arm64 21.5.0

Around 2 million characters. But extremely fast on my native terminal.

https://user-images.githubusercontent.com/16152305/174429543-b3b91608-7132-447c-a3cd-08ca765ce186.mov

Contributor guide

Tech stack
typescript
Domain
desktopperformance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
TypeScriptVSCode build systemProfilingTerminal rendering
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the terminal search implementation in the vscode codebase, likely in src/vs/workbench/parts/terminal. Refer to issue #147685 for similar performance improvements. Profile the search operation with large scrollback using the built in profiler or Chrome DevTools to identify bottlenecks. Focus on the rendering of wrapped lines and text buffer handling.