Microsoft/vscode

Image stays broken when re-executing Markdown cell

Open

#151,151 opened on May 30, 2022

View on GitHub
 (15 comments) (1 reaction) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
buggood first issuehelp wantednotebook

Description

Applies To

  • Notebooks (.ipynb files)
  • Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?

  1. Create a Markdown cell with an tag referring to a non-existing path, e.g. <img src="myimg.png">.
  2. Execute the cell. A "broken image" icon appears.
  3. Create the image at the specified path.
  4. Click the cell to edit. Re-execute it (without making any changes).

Expected result: the image is now shown.

Actual result: still shows a broken image icon. (The image is only shown after making a change to the cell itself.)

VS Code Version

1.67.2

Jupyter Extension Version

v2022.4.1021342353

Jupyter logs

No response

Coding Language and Runtime Version

Markdown

Language Extension Version (if applicable)

No response

Anaconda Version (if applicable)

No response

Running Jupyter locally or remotely?

Local

Contributor guide

Tech stack
typescriptnodejs
Domain
desktopfrontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with VS Code extension developmentBasic knowledge of Markdown
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
This issue concerns the Jupyter extension for VS Code. To resolve, investigate the Markdown cell rendering code, likely in the notebook renderer module. Focus on how <img> tags are processed and how the cell output is updated when the cell is re executed without content changes. Look for cached image URLs that are not refreshed. Consider adding a test that simulates this scenario.