Microsoft/vscode

Both custom editors are reloaded when clicking on a diff tab if it's already opened

Open

#143,423 opened on Feb 18, 2022

View on GitHub
 (0 comments) (0 reactions) (1 assignee)TypeScript (10,221 forks)batch import
bugcustom-editorshelp wantedworkbench-tabs

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Repro:

  1. Install Luna Paint
  2. Make a change to an image
  3. Save it
  4. Click the change in the SCM view, the diff should load
  5. Click the tab, the diff custom editors will both reload

This doesn't seem to happen with text editors.

No gif as gifcap is acting up on edge and safari atm.

Contributor guide

Research direction
Investigate the code path for custom editor reload when clicking a diff tab. Look at the editor group and tab handling logic in VS Code's source, specifically around how custom editors are cached and reused compared to text editors.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70