Microsoft/vscode

explorer.sortOrder default doesn't work well for hashes

Open

#140,915 opened on Jan 18, 2022

View on GitHub
 (7 comments) (0 reactions) (1 assignee)TypeScript (10,221 forks)batch import
feature-requestfile-explorerhelp wanted

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

image

With this folder https://github.com/lunapaint/imagetestsuite/tree/main/png, it starts off alphabetical but gives up shortly after. It looks like the it's sorting by the number first such that 3, 20, 100 appear in the "correct" order. I suggest making one of the following changes:

  • Only use that rule when the file name excluding the extension is a number (not sure what cases are being covered)
  • Add a setting for actual alphabetical sorting
  • My preference: Sort alphabetical if the file name looks like a hash (/[0-9a-f]{7,32}/)

Have been hitting this a decent amount recently, instead of a quick find via visual check I need to type out the first part of the hash to filter the explorer.

image

Contributor guide

Research direction
Investigate the current sorting implementation in the explorer file list, particularly the logic that handles numeric substrings. Look into the function that compares file names and understand why it fails for hashes. Propose a fix that either sorts alphabetically when the filename looks like a hash or improves the numeric sorting rule.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50