Microsoft/vscode

Webview find doesn't play nicely with keyboard

Open

#140,424 opened on Jan 10, 2022

View on GitHub
 (3 comments) (0 reactions) (1 assignee)TypeScript (10,221 forks)batch import
bughelp wantedwebview

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

The below gif shows find next/previous via tab and enter. For find next it skips over an item and for find previous it does nothing.

Recording 2022-01-10 at 07 06 55

Version: 1.64.0-insider (user setup) Commit: a06afb22ce06dbd4f01d3bb5bf946e08bff55180 Date: 2022-01-10T05:16:12.944Z Electron: 13.5.2 Chromium: 91.0.4472.164 Node.js: 14.16.0 V8: 9.1.269.39-electron.0 OS: Windows_NT x64 10.0.22000

Contributor guide

Research direction
Investigate the keyboard event handling for find next/previous in webview. Check the code that handles tab and enter keys in find widget.
Tech stack
typescriptelectron
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.jsTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65