Microsoft/vscode

Restore all windows when closing them all at once

Open

#134,336 opened on Oct 2, 2021

View on GitHub
 (14 comments) (7 reactions) (1 assignee)TypeScript (10,221 forks)batch import
feature-requesthelp wantedlinuxwindowsworkbench-window

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.60.2
  • OS Version: Ubuntu 21.04 / Gnome

Steps to Reproduce:

  1. Open two windows (optional : open folder/files, do some modifications and save them), then click on "Quit 2 Windows" to quit VS Code :

Screenshot

  1. Open VS Code again : only the last active window is reopened (no matter what value is set in window.restoreWindows)

However, if VS Code is closed by another mean (like pkill code), on the second launch all windows are correctly restored. What is causing this behaviour, and how to fix it ?

Contributor guide

Research direction
Investigate the window restoration logic in VS Code, specifically how the 'Quit 2 Windows' action triggers the close event and how the state is saved. Trace the code path from the menu action to the window management service to understand why only the last active window is restored. Check the electron window management and state persistence code.
Tech stack
typescript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35