Microsoft/vscode

StatusBarItem.tooltip2 right border doesn't show when window is narrow

Open

#127,438 opened on Jun 29, 2021

View on GitHub
 (0 comments) (0 reactions) (1 assignee)TypeScript (10,221 forks)batch import
help wantedpolishworkbench-hover

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Testing #127372

Using statusbar-sample with the following change:

(myStatusBarItem as any).tooltip2 = new vscode.MarkdownString('kjdsalkjndkjans dlkjnaskdjnalsjdk kjdsalkjndkjansdlkjnas kdjnalsjdk kjds alkj ndkj ansdl kjna skdj nalsjdk kjdsalkjndkjansdlkjna skdjnalsjdk kjdsalkjndkjansdlkjnaskdjnalsjdk kjdsalkjndkjansdlkjnaskdjnalsjdk kjdsalkjndkjansdlkjnaskdjnalsjdk kjdsalkjndkjansdlkjnaskdjnalsjdk kjdsalkjndkjansdlkjnaskdjnalsjdk kjdsalkjndkjansdlkjnaskdjnalsjdk kjdsalkjndkjansdlkjnaskdjnalsjdk $(zap) blah');

Results in a cut off hover, the text wraps fine but the right border is missing. Maybe a 1-off error?

image

Code pointer: https://github.com/microsoft/vscode/blob/96e6d1c933c315fd98fa1d5f0e96211fcb150124/src/vs/workbench/services/hover/browser/hoverWidget.ts#L182-L182

Contributor guide

Research direction
Inspect the hover widget code at the given pointer to find the off by one error causing the right border to be cut off.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70