Microsoft/vscode

Git - Adding a folder to `.gitignore` should not add every single file

Open

#127,028 opened on Jun 23, 2021

View on GitHub
 (7 comments) (3 reactions) (1 assignee)TypeScript (10,221 forks)batch import
feature-requestgithelp wanted

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

  • VS Code Version: v1.57.1
  • OS Version: Win 20H1

Steps to Reproduce:

  1. Create an empty repository
  2. Do npm init && npm install whatever
  3. Switch to the SVM view
  4. Oops, you have one bajillion changed files in your working copy! Right-click the node_modules folder in the SCM view and choose "Add to .gitignore".

Expected behavior:

  • node_modules/ is added to the .gitignore.

Actual behavior:

  • Every single file in the node_modules subtree of the repository is added separately to the .gitignore ...

Contributor guide

Research direction
Find the implementation of the "Add to .gitignore" context menu action in the SCM view and correct the logic to add the folder pattern (e.g., `node modules/`) instead of iterating over all files within the folder.
Tech stack
typescript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70