Microsoft/vscode

Git - Discarding changes on open file error

Open

#114,374 opened on Jan 14, 2021

View on GitHub
 (7 comments) (0 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
buggithelp wanted

Description

Hi, In the source control view, using Git, if I try to discard changes on a file that is currently open (specifically, a CSV file open in Excel), I get an error message that is about arguments being wrong. I would imagine it should give me a file is open error instead of something about arguments.

Contributor guide

Tech stack
typescript
Domain
desktopdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptGitVS Code extension API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Look at the Git extension in vscode, specifically the 'discard' command handler in extensions/git/src/commands.ts. The error is thrown when a file is locked by another process (e.g., Excel). Check how errors are caught and consider providing a more descriptive message like 'File is currently open in another application'. Review issue comments for additional context and possible test scenarios.