Microsoft/vscode

Git - Improve missing Git user/name behavior

Open

#114,049 opened on Jan 8, 2021

View on GitHub
 (5 comments) (5 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
feature-requestgithelp wanted

Description

@CoreTechnologyAG @GuilhermeAbacherli I know how to resolve it, the reason why I opened this issue is because i think it can be done better. @eamodio could you take a Look at our suggestions? They are as following: Suggestion 1: Make an option in the settings to enable/disable auto-detect Suggestion 2: Make it a Warning instead of an error (Like git does as well) Suggestion 3: Give us the option to set user.name and user.email directly from VS Code (By @mrwensveen and @abby-d )

Originally posted by @michvllni in https://github.com/microsoft/vscode/issues/112294#issuecomment-747276997

Contributor guide

Tech stack
typescript
Domain
developer experiencetooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
TypeScriptGitVS Code extension APIunderstanding of Git config
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue proposes three suggestions to improve handling of missing Git user.name/email. To implement, examine the VS Code Git extension (likely in 'extensions/git'). Check the referenced issue #112294 for prior discussion. Look at how Git errors are currently surfaced (maybe in 'src/git.ts' or similar). Consider adding a setting to disable auto detect, converting the error to a warning, or providing UI to set user.name/email. Also check if any PRs address this.