Microsoft/vscode

SCM - go to next/previous change (Alt-F5) should cycle between files

Open

#111,596 opened on Dec 1, 2020

View on GitHub
 (4 comments) (35 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
feature-requesthelp wantedscm

Description

In #18059, @Tyriar requested that this work like "go to next problem" (F8), but the way it's been implemented there's a crucial difference - upon reaching the end of the file, it goes back to the top, rather than the next changed file! This means, for example, that when reviewing changes prior to staging, I end up running git diff in a terminal to avoid a lot of fiddly mouse clicking. Any other power user surely does the same. This is a shame, since VScode has replaced every other one of my everyday uses of git.

I see no reason anyone would be opposed to this change.

Contributor guide

Tech stack
typescript
Domain
desktopdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptVS Code extension APIGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The issue requests that Alt F5 (go to next change) should cycle across files, similar to how F8 cycles through problems. The prior discussion in issue #18059 and the current implementation should be studied. The SCM extension in VS Code handles change tracking; the relevant code likely resides in extensions/git or src/vs/workbench/contrib/scm. To implement, one could examine how 'go to next problem' works (likely in problems extension) and adapt it to SCM changes. The assigned developer may have left comments; check the issue for any linked PRs or further clarification.