Microsoft/vscode

Add selection to next Find match does not work with Regex Find Mode

Open

#107,090 opened on Sep 20, 2020

View on GitHub
 (7 comments) (10 reactions) (2 assignees)TypeScript (74,848 stars) (10,221 forks)batch import
bugeditor-findeditor-multicursorgood first issuehelp wanted

Description

Description

Adding selection to next find match does not work when the regex find mode is turned on. I am not sure this is intended, but based on #5715 I would assume you would want this to work along with adding everything to the selection so I'm calling it a bug.

I made an example of this in the gif below while in an instance with extensions disabled by running code --disable-extensions and with me just trying to add to the selection using ctrl+d

VscodeRegexctrld

Version Info

VSCode Version: 1.48.2 (system setup) Commit: a0479759d6e9ea56afa657e454193f72aef85bd0 Date: 2020-08-25T10:13:11.295Z Electron: 7.3.2 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0.18363

Steps to Reproduce:

  1. Open any document with some text
  2. Turn on the regex mode for the search tool
  3. Add some valid regex pattern
  4. Attempt to add another cursor by pressing ctrl+d

Does this issue occur when all extensions are disabled?: Yes

Contributor guide

Tech stack
typescriptjavascript
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with VS Code codebaseRegex knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the find widget implementation in VS Code's source code, specifically the logic for 'Add Selection to Next Find Match' with regex mode. The issue references #5715 which may provide additional context. The relevant code is likely in 'src/vs/editor/contrib/find' directory. Since there are assignees, check their progress or any linked branches.