Microsoft/vscode

macOS: Crash when using `fs.watch` for network drives

Open

#106,879 opened on Sep 16, 2020

View on GitHub
 (21 comments) (3 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
bugconfirmedfile-iofile-watcherfreeze-slow-crash-leakhelp wantedmacosnodejsupstreamupstream-issue-pending

Description

On MacOS 10.15 when a file is open from an SMB share if connection t othe SMB share is lost the entire editor crashes.

To repro: Open finder and Connect to Server open a file from the mapped SMB drive in VS Code disconnect the network return to VS Code VS Code crashes

Expected behavior would be 'file no longer exists' or something similar

Contributor guide

Tech stack
typescriptnodejselectron
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Node.js fs moduleUnderstanding of Electron main process
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the crash in VS Code's file watching when network connection drops on macOS. Start by examining the file watcher implementation in src/vs/platform/files/node/watcher.ts. Review the Electron NativeFileWatcher behavior on macOS, possibly related to an existing Electron issue. Check comments in the issue for any suggested fixes or workarounds. Consider testing with a minimal Electron app using fs.watch on SMB shares to isolate the problem.