Microsoft/react-native-windows

Add Windows as a platform filter to redesigned RNTester

Open

#6314 opened on Oct 23, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (6,114 stars) (544 forks)batch import
Area: Developer ExperienceUpstreamWorkstream: Gallery and Samplesenhancementgood first issuenice-to-have

Description

The redesigned RNTester shows what tests are platform specific and allows filtering. It doesn't know about Windows or Windows custom example pages, and shows them as supporting both Android and iOS if we don't specify a platform.

image

This is fairly low priority, but we could either fork or try to make this more extensible upstream if we cared about this functionality working correctly on Windows.

Contributor guide

Tech stack
reactreact nativetypescript
Domain
frontendtesting
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React Native basicsUnderstanding of RNTester
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Check the RNTester source code in the react native windows repo for platform filtering logic. The issue mentions that without a platform specification, Windows tests show as supporting both Android and iOS. Look for the component that renders platform badges and add a Windows identifier. Consider the maintainer's suggestion to make it extensible upstream. Possibly modify files like RNTesterPlatformFilter.js or similar.