Microsoft/react-native-windows

Add isComposing to onKeyDown/onKeyUp

Open

#5,821 opened on Aug 24, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (544 forks)batch import
Needs: Dev DesignPartner: FacebookWorkstream: Component Parityenhancementhelp wanted

Repository metrics

Stars
 (6,114 stars)
PR merge metrics
 (Avg merge 4d 14h) (45 merged PRs in 30d)

Description

See comment for context. Copying from necolas's comment:

The event has an isComposing property set to true in that case. However, it's a bit more complicated (and inconsistent across browsers) than that and there has been discussion about what the timing of the composition events (compositionstart, compositionend [ref]) and when the isComposing property should be true. So in practice, on the web you also have to check whether the keyCode is a magic number 229 which indicates IME composition.

The work I'm doing on interactions will probably add onCompositionStart/End events and prevent all IME events from triggering onKeyDown and onKeyUp events, as the vast majority of developers aren't aware of IME and end up breaking things by acting on key events like Enter that are actually occurring during composition.

Some IME-related discussion here: necolas/react-native-web#1538 (comment)

Contributor guide