Microsoft/react-native-windows

Add support for device orientation

Open

#3595 opened on Nov 5, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C# (6,114 stars) (544 forks)batch import
API: CompletionNeeds WinUI 3Workstream: Component Parityenhancementhelp wanted

Description

RN4W is missing support for the "namedOrientationDidChange" event, which is supposed to be raised when the device orientation changes.

Currently, the Modal component uses this event, but apps are also free to subscribe to the event for other reasons.

See: https://facebook.github.io/react-native/docs/modal#onorientationchange https://facebook.github.io/react-native/docs/modal#supportedorientations

Contributor guide

Tech stack
javascriptcppreact
Domain
mobile
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with React Native event systemUnderstanding of Windows Runtime
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The issue requests adding the 'namedOrientationDidChange' event to React Native Windows. Investigate the existing event infrastructure in the repository, likely in files like 'ReactNativeWindows/ReactUWP/...' or 'ReactNativeWindows/ReactNativeWindows/...'. Look at how similar events are implemented (e.g., orientation events on Android/iOS). The comments may provide additional context on implementation details or blockers. Consider linking to the referenced React Native documentation for event specification.