Microsoft/react-native-windows

Add support for device orientation

Open

#3,595 opened on Nov 5, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C# (544 forks)batch import
API: CompletionNeeds WinUI 3Workstream: Component Parityenhancementhelp wanted

Repository metrics

Stars
 (6,114 stars)
PR merge metrics
 (Avg merge 4d 14h) (45 merged PRs in 30d)

Description

RN4W is missing support for the "namedOrientationDidChange" event, which is supposed to be raised when the device orientation changes.

Currently, the Modal component uses this event, but apps are also free to subscribe to the event for other reasons.

See: https://facebook.github.io/react-native/docs/modal#onorientationchange https://facebook.github.io/react-native/docs/modal#supportedorientations

Contributor guide

Research direction
Examine the existing orientation event handling in React Native Windows, specifically how the Modal component triggers onOrientationChange. Then implement the namedOrientationDidChange event by adding the corresponding native module code and wiring it up in the JavaScript layer.
Tech stack
reactcsharp
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React NativeC#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55