Microsoft/react-native-windows

Add Functional Tests for Touchable Highlight

Open

#12465 opened on Nov 29, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (6,114 stars) (544 forks)batch import
Area: FabricArea: TestsNew ArchitectureWorkstream: Test Coverageenhancementgood first issue

Description

Test cases should be added to the E2E test app (Fabric) to validate the following functionality scenarios.

### Tasks
- [ ] TouchableHighlight should update style upon fast refresh.
- [ ] TouchableHighlight should update underlayColor upon fast refresh.
- [ ] TouchableHighlight should update activeOpacity upon fast refresh.
- [x] TouchableHighlight should fire action upon press.
- [x] TouchableHighlight should fire action upon onPressIn.
- [x] TouchableHighlight should fire action upon onPressOut.
- [ ] TouchableHighlight should fire action upon onLongPress.
- [ ] TouchableHighlight should register press in clicked within hitSlop range.
- [x] TouchableHighlight should not be interactable when disabled.

Contributor guide

Tech stack
javascripttypescript
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React Native testing basicsE2E test setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Locate the E2E test app (Fabric) in the repository, likely under packages/e2e test app or similar. Review existing tests for TouchableHighlight to understand the testing patterns. Implement tests for the remaining unchecked tasks: fast refresh, underlayColor, activeOpacity, and hitSlop. Follow the pattern of already completed tasks (like onPress, onPressIn, etc.). Run the tests locally to ensure they pass.