Microsoft/react-native-windows

Add E2E Snapshot Tests for View

Open

#11,313 opened on Feb 27, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (544 forks)batch import
Area: FabricArea: PaperArea: TestsArea: ViewArea: View Style PropsNew ArchitectureOld ArchitectureWorkstream: Test Coverageenhancementgood first issue

Repository metrics

Stars
 (6,114 stars)
PR merge metrics
 (Avg merge 4d 14h) (45 merged PRs in 30d)

Description

Add E2E Jest Snapshot Tests for View. Tests should exist as samples within RNTester.

STATUS TYPES

Status Description
Not Implemented Prop is not implemented for given architecture.
Not Completed No test or sample exists for the prop.
Sample Completed Sample exists for the prop, but sample is not run in a Jest Snapshot Test.
Completed Sample and Snapshot test exists for the prop.

PROPS STATUS FOR View

Test Description Status (Paper) Status (Fabric) Notes
Default [x] Completed – RNTester [x] Completed – RNTester
AccessibilityHint [ ] Not Completed [x] Completed – RNTester
AccessibilityLabel [ ] Not Completed [x] Completed – RNTester
AccessibilityActions [ ] Not Completed [x] Completed – RNTester
AccessibilityRole [ ] Not Completed [x] Completed – RNTester
AccessibilityValue [ ] Not Completed [x] Completed – RNTester
AccessibilityPosInSet [ ] Not Completed [x] Completed
AccessibilitySetSize [ ] Not Completed [x] Completed
AccessibilityLiveRegion [ ] Not Completed [x] Completed
AccessibilityState [ ] Not Completed [x] Completed
ImportantforAccessibility – no-hide-descendants [x] Completed – RNTester [ ] Not Completed
testID [x] Completed – RNTester [x] Completed
Style – backgroundColor [x] Completed – RNTester [x] Completed
Style – borderBottomColor Not Implemented [ ] Not Completed
Style – borderBottomEndRadius [x] Completed – RNTester [ ] Not Completed
Style – borderBottomLeftRadius [x] Completed – RNTester [x] Completed
Style – borderBottomRightRadius [x] Completed – RNTester [x] Completed
Style – borderBottomStartRadius [x] Completed – RNTester [ ] Not Completed
Style – borderBottomWidth [x] Completed – RNTester [x] Completed
Style – borderColor [x] Completed – RNTester [x] Completed
Style – borderEndColor Not Implemented [ ] Not Completed
Style – borderLeftColor Not Implemented [ ] Not Completed
Style – borderLeftWidth [x] Completed – RNTester [x] Completed
Style – borderRightWidth [x] Completed – RNTester [x] Completed
Style – borderRightColor Not Implemented [ ] Not Completed
Style – borderRadius [x] Completed – RNTester [x] Completed
Style – borderStartColor Not Implemented [ ] Not Completed
Style – borderStyle Not Implemented [x] Completed
Style – borderTopColor Not Implemented [ ] Not Completed
Style – borderTopEndRadius [x] Completed – RNTester [ ] Not Completed
Style – borderTopLeftRadius [x] Completed – RNTester [x] Completed
Style – borderTopRightRadius [x] Completed – RNTester [x] Completed
Style – borderTopStartRadius [x] Completed – RNTester [ ] Not Completed
Style – borderTopWidth [x] Completed – RNTester [x] Completed
Style – borderWidth [x] Completed – RNTester [x] Completed
Style – elevation Not Implemented [ ] Not Completed
Style – opacity [x] Completed – RNTester [x] Completed
Style – height [x] Completed – RNTester [x] Completed
Style – width [x] Completed – RNTester [x] Completed
Style – overflow [x] Completed – RNTester [x] Completed
Style – backfaceVisibility [x] Completed – RNTester [x] Completed
Accessible [x] Completed – RNTester [x] Completed
Focusable [x] Completed – RNTester [x] Completed
HitSlop [x] Completed – RNTester [x] Completed
NativeID [x] Completed – RNTester [x] Completed
NextFocus* [ ] Not Completed [ ] Not Completed
onAccessibilityAction [x] Completed – RNTester [x] Completed
onAccessibilityTab [x] Completed – RNTester [x] Completed
onAccessibilityEscape [ ] Not Completed [ ] Not Completed
onLayout [ ] Not Completed [ ] Not Completed
onMoveShoudlSetResponder [ ] Not Completed [ ] Not Completed
onMoveShouldSetResponderCapture [ ] Not Completed [ ] Not Completed
onResponderGrant [ ] Not Completed [ ] Not Completed
onResponderMove [x] Completed – RNTester [ ] Not Completed
onResponserReject [x] Completed – RNTester [ ] Not Completed
onResponderRelease [x] Completed – RNTester [ ] Not Completed
onResponderTerminate [ ] Not Completed [ ] Not Completed
onResponderTerminationRequest [ ] Not Completed [ ] Not Completed
onStartShouldSetResponder [x] Completed – RNTester [ ] Not Completed
onStartShouldSetResponderCatpure [ ] Not Completed [ ] Not Completed
pointerEvents [ ] Not Completed [ ] Not Completed
removeClippedSubviews [ ] Not Completed [ ] Not Completed
needsOffscreenAlphaCompositioning [x] Completed – RNTester [x] Completed
toolTip [x] Completed – RNTester [x] Completed

Contributor guide

Research direction
Review existing snapshot tests in RNTester to understand the pattern for creating E2E Jest snapshot tests for the View component. Identify props that are not yet tested in both Paper and Fabric architectures, and create test samples and snapshot tests for each.
Tech stack
react nativejavascripttypescript
Domain
mobiledesktoptesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React NativeJestSnapshot testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60