Microsoft/react-native-windows

Add E2E Snapshot Tests for TouchableHighlight

Open

#11,310 opened on Feb 27, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (544 forks)batch import
Area: FabricArea: TestsArea: TouchableHighlightNew ArchitectureWorkstream: Test Coverageenhancementgood first issue

Repository metrics

Stars
 (6,114 stars)
PR merge metrics
 (Avg merge 4d 14h) (45 merged PRs in 30d)

Description

Add E2E snapshot tests for the TouchbleHighlight components. Snapshots should dump the contents of the Composition Visual Tree and the Accessibility Tree.

STATUS TYPES

Status Description
Not Implemented Prop is not implemented for given architecture.
Not Completed No test or sample exists for the prop.
Sample Completed Sample exists for the prop, but sample is not run in a Jest Snapshot Test.
Completed Sample and Snapshot test exists for the prop.

PROPS STATUS FOR TOUCHABLEHIGHLIGHT

Test Description Status (Paper) Status (Fabric) Notes
Default - Text Child [x] Sample Completed – RNTester [x] Completed
Default - Image Child [x] Sample Completed – RNTester [x] Completed
AccessibilityHint [ ] Not Completed [ ] Not Completed
AccessibilityLabel [ ] Not Completed [x] Completed
AccessibilityActions [ ] Not Completed [ ] Not Completed
AccessibilityRole [ ] Not Completed [x] Completed
AccessibilityValue [ ] Not Completed [x] Completed
AccessibilityPosInSet [ ] Not Completed [x] Completed
AccessibilitySetSize [ ] Not Completed [x] Completed
AccessibilityLiveRegion [ ] Not Completed [x] Completed
ImportantforAccessibility – no-hide-descendants [ ] Not Completed [ ] Not Completed
testID [x] Sample Completed – RNTester [ ] Not Completed
Style – backgroundColor [x] Sample Completed – RNTester [ ] Not Completed
Style – borderBottomColor Not Implemented [ ] Not Completed
Style – borderBottomEndRadius [ ] Not Completed [ ] Not Completed
Style –borderBottomLeftRadius [ ] Not Completed [ ] Not Completed
Style – borderBottomRightRadius [ ] Not Completed [ ] Not Completed
Style – borderBottomStartRadius [ ] Not Completed [ ] Not Completed
Style – borderBottomWidth [ ] Not Completed [ ] Not Completed
Style – borderColor [ ] Not Completed [ ] Not Completed
Style – borderEndColor Not Implemented [ ] Not Completed
Style – borderLeftColor Not Implemented [ ] Not Completed
Style – borderLeftWidth [ ] Not Completed [ ] Not Completed
Style – borderRadius [x] Sample Completed – RNTester [x] Completed
Style – borderRightColor Not Implemented [ ] Not Completed
Style – borderStartColor Not Implemented [ ] Not Completed
Style – borderStyle [ ] Not Completed [ ] Not Completed
Style – borderTopColor Not Implemented [ ] Not Completed
Style – borderTopEndRadius [ ] Not Completed [ ] Not Completed
Style – borderTopLeftRadius [ ] Not Completed [ ] Not Completed
Style – borderTopRightRadius [ ] Not Completed [ ] Not Completed
Style – borderTopStartRadius [ ] Not Completed [ ] Not Completed
Style – borderTopWidth [ ] Not Completed [ ] Not Completed
Style – borderWidth [x] Sample Completed – RNTester [ ] Not Completed
Style – elevation Not Implemented [ ] Not Completed
Style – opacity [ ] Not Completed [ ] Not Completed
Style – height [ ] Not Completed [x] Completed
Style – width [ ] Not Completed [x] Completed
Style – overflow [ ] Not Completed [ ] Not Completed
Style – backfaceVisibility [ ] Not Completed [ ] Not Completed
Accessible [ ] Not Completed [ ] Not Completed
Focusable [ ] Not Completed [ ] Not Completed
HitSlop [ ] Not Completed [ ] Not Completed
NativeID [ ] Not Completed [ ] Not Completed
NextFocus* [ ] Not Completed [ ] Not Completed
onAccessibilityAction [ ] Not Completed [ ] Not Completed
onAccessibilityTab [ ] Not Completed [ ] Not Completed
onAccessibilityEscape [ ] Not Completed [ ] Not Completed
onLayout [ ] Not Completed [ ] Not Completed
onMoveShoudlSetResponder [ ] Not Completed [ ] Not Completed
onMoveShouldSetResponderCapture [ ] Not Completed [ ] Not Completed
onResponderGrant [ ] Not Completed [ ] Not Completed
onResponderMove [ ] Not Completed [ ] Not Completed
onResponserReject [ ] Not Completed [ ] Not Completed
onResponderRelease [ ] Not Completed [ ] Not Completed
onResponderTerminate [ ] Not Completed [ ] Not Completed
onResponderTerminationRequest [ ] Not Completed [ ] Not Completed
onStartShouldSetResponder [ ] Not Completed [ ] Not Completed
onStartShouldSetResponderCatpure [ ] Not Completed [ ] Not Completed
pointerEvents [ ] Not Completed [ ] Not Completed
removeClippedSubviews [ ] Not Completed [ ] Not Completed
needsOffscreenAlphaCompositioning [ ] Not Completed [ ] Not Completed
toolTip [ ] Not Completed [ ] Not Completed
activeOpacity [x] Sample Completed – RNTester [x] Completed
onHideUnderlay [x] Sample Completed – RNTester [x] Sample Completed
onShowUnderlay [x] Sample Completed – RNTester [x] Sample Completed
underlayColor [x] Sample Completed – RNTester [x] Completed
testOnly_pressed [ ] Not Completed [ ] Not Completed
onPress [x] Sample Completed – RNTester [x] Completed
onPressIn [ ] Not Completed [x] Completed
onLongPress [ ] Not Completed [x] Completed
delayPressIn [ ] Not Completed [x] Completed
delayPressOut [ ] Not Completed [x] Completed
delayLongPress [ ] Not Completed [x] Completed
disabled [x] Sample Completed – RNTester [x] Sample Completed
onFocus [x] Sample Completed – RNTester [x] Not Completed
onBlur [ ] Not Completed [ ] Not Completed

Contributor guide

Research direction
Explore the existing snapshot tests for other components in the repo (e.g., TouchableOpacity) to understand the pattern. Then pick a prop with status 'Not Completed' and create a sample component and snapshot test for it. Run the tests locally using the provided scripts.
Tech stack
csharpreactjavascripttypescript
Domain
frontendtesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React NativeJest snapshot testingGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70