Microsoft/react-native-windows

Add E2E Snapshot Tests for Pressable

Open

#11,295 opened on Feb 24, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (544 forks)batch import
Area: FabricArea: PressableArea: TestsNew ArchitectureWorkstream: Test Coverageenhancementgood first issue

Repository metrics

Stars
 (6,114 stars)
PR merge metrics
 (Avg merge 4d 14h) (45 merged PRs in 30d)

Description

Add E2E Snapshot tests for the Pressable component. We should take snapshots of the composition and accessibility tree for each example.

STATUS TYPES

Status Description
Not Implemented Prop is not implemented for given architecture.
Not Completed No test or sample exists for the prop.
Sample Completed Sample exists for the prop, but sample is not run in a Jest Snapshot Test.
Completed Sample and Snapshot test exists for the prop.

PROPS STATUS FOR PRESSABLE

Test Description Status (Paper) Status (Fabric) Notes
Default [x] Completed – RNTester [x] Completed
AccessibilityHint [x] Completed - RNTester [x] Completed
AccessibilityLabel [x] Completed - RNTester [x] Completed
AccessibilityActions [ ] Not Completed [ ] Not Completed
AccessibilityRole [x] Completed - RNTester [x] Completed
AccessibilityValue [x] Completed - RNTester [x] Completed
AccessibilityPosInSet [ ] Not Completed [x] Completed
AccessibilitySetSize [ ] Not Completed [x] Completed
AccessibilityLiveRegion [x] Completed – RNTester [x] Completed
ImportantforAccessibility – no-hide-descendants [x] Completed - RNTester [x] Completed
testID [x] Completed - RNTester [x] Completed
Style – backgroundColor [x] Completed - RNTester [x] Completed
Style – borderBottomColor Not Implemented [ ] Not Completed
Style – borderBottomEndRadius [x] Completed - RNTester [x] Completed
Style –borderBottomLeftRadius [x] Completed - RNTester [ ] Not Completed
Style – borderBottomRightRadius [x] Completed - RNTester [ ] Not Completed
Style – borderBottomStartRadius [x] Completed - RNTester [x] Completed
Style – borderBottomWidth [x] Completed - RNTester [x] Completed
Style – borderColor [x] Completed - RNTester [x] Completed
Style – borderEndColor Not Implemented [ ] Not Completed
Style – borderLeftColor Not Implemented [ ] Not Completed
Style – borderLeftWidth [x] Completed - RNTester [x] Completed
Style – borderRadius [x] Completed - RNTester [x] Completed
Style – borderRightColor Not Implemented [ ] Not Completed
Style – borderStartColor Not Implemented [ ] Not Completed
Style – borderStyle Not Implemented [ ] Not Completed
Style – borderTopColor Not Implemented [ ] Not Completed
Style – borderTopEndRadius [x] Completed - RNTester [x] Completed
Style – borderTopLeftRadius [x] Completed - RNTester [ ] Not Completed
Style – borderTopRightRadius [x] Completed - RNTesterd [ ] Not Completed
Style – borderTopStartRadius [x] Completed - RNTester [x] Completed
Style – borderTopWidth [x] Completed - RNTester [x] Completed
Style – borderWidth [x] Completed - RNTester [ ] Not Completed
Style – elevation Not Implemented [ ] Not Completed
Style – opacity [x] Completed - RNTester [x] Completed
Style – height [x] Completed - RNTester [x] Completed
Style – width [x] Completed - RNTester [x] Completed
Style – backfaceVisibility [x] Completed - RNTester [x] Completed
Accessible [x] Completed - RNTester [x] Completed
Focusable [x] Completed - RNTester [x] Completed
HitSlop [x] Completed - RNTester [x] Completed
NativeID [x] Completed - RNTester [x] Completed
NextFocus* Not Implemented [ ] Not Completed
onAccessibilityAction [ ] Not Completed [ ] Not Completed
onAccessibilityTab [ ] Not Completed [ ] Not Completed
onAccessibilityEscape [ ] Not Completed [ ] Not Completed
onLayout [ ] Not Completed [ ] Not Completed
onMoveShoudlSetResponder [ ] Not Completed [ ] Not Completed
onMoveShouldSetResponderCapture [ ] Not Completed [ ] Not Completed
onResponderGrant [ ] Not Completed [ ] Not Completed
onResponderMove [ ] Not Completed [ ] Not Completed
onResponserReject [ ] Not Completed [ ] Not Completed
onResponderRelease [ ] Not Completed [ ] Not Completed
onResponderTerminate [ ] Not Completed [ ] Not Completed
onResponderTerminationRequest [ ] Not Completed [ ] Not Completed
onStartShouldSetResponder [ ] Not Completed [ ] Not Completed
onStartShouldSetResponderCatpure [ ] Not Completed [ ] Not Completed
pointerEvents [ ] Not Completed [ ] Not Completed
removeClippedSubviews [ ] Not Completed [ ] Not Completed
needsOffscreenAlphaCompositioning [ ] Not Completed [ ] Not Completed
toolTip [x] Completed - RNTester [x] Completed
children [x] Completed - RNTester [ ] Not Completed
unstable_pressDelay [ ] Not Completed [ ] Not Completed
delayLongPress [x] Completed - RNTester [x] Completed
onLongPress [x] Completed - RNTester [x] Completed
onPress [x] Completed - RNTester [x] Completed
onPressIn [x] Completed - RNTester [x] Completed
onPressOut [x] Completed - RNTester [ ] Not Completed
pressRetentionOffset [x] Completed - RNTester [ ] Not Completed
testOnly_pressed [ ] Not Completed [ ] Not Completed
Disabled [x] Completed - RNTester [x] Completed
{pressed} [x] Completed - RNTester [x] Completed
onHoverIn [x] Completed - RNTester [x] Completed
onHoverOut [x] Completed - RNTester [x] Completed
onFocus [ ] Not Completed [x] Completed
onBlur [ ] Not Completed [x] Completed
onKeyUp [ ] Not Completed [x] Completed
onKeyDown [ ] Not Completed [x] Completed
onKeyDownCapture [ ] Not Completed [x] Completed
keyDownEvents [ ] Not Completed [x] Completed
aria-label [ ] Not Completed [x] Completed

Contributor guide

Research direction
Review the existing snapshot test patterns in the repository (e.g., tests folders). Focus on adding Jest snapshot tests for the Pressable component's props that are marked as 'Not Completed' in the issue table. Follow the structure of similar tests for other components like Button or Text.
Tech stack
javascripttypescriptreactreact native
Domain
frontendmobiletesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.jsReact Native testing experience
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70