Microsoft/react-native-windows

Add E2E Snapshot Tests for Image

Open

#11281 opened on Feb 23, 2023

View on GitHub
 (3 comments) (0 reactions) (1 assignee)C# (6,114 stars) (544 forks)batch import
Area: FabricArea: ImageArea: TestsNew ArchitectureWorkstream: Test Coverageenhancementgood first issue

Description

Add E2E Jest Snapshot Tests for Image. Tests should exist as samples within RNTester.

STATUS TYPES

Status Description
Not Implemented Prop is not implemented for given architecture.
Not Completed No test or sample exists for the prop.
Sample Completed Sample exists for the prop, but sample is not run in a Jest Snapshot Test.
Completed Sample and Snapshot test exists for the prop.

PROPS STATUS FOR IMAGE

Test Description Status (Paper) Status (Fabric) Notes
Default [x] Sample Completed – RNTester [x] Completed
AccessibilityHint [ ] Not Completed [x] Completed
AccessibilityLabel [x] Sample Completed - RNTester [x] Completed
AccessibilityActions [ ] Not Completed [x] Completed
AccessibilityRole [ ] Not Completed [x] Completed
AccessibilityValue [ ] Not Completed [x] Completed
AccessibilityPosInSet [ ] Not Completed [x] Completed
AccessibilitySetSize [ ] Not Completed [x] Completed
AccessibilityLiveRegion [x] Completed – RNTester [x] Completed
ImportantforAccessibility – no-hide-descendants [ ] Not Completed [x] Completed
testID [ ] Not Completed [x] Completed
Style – backgroundColor [x] Sample Completed - RNTester [x] Completed
Style – borderBottomColor Not Implemented [x] Completed
Style – borderBottomEndRadius [ ] Not Completed [x] Completed
Style –borderBottomLeftRadius [x] Sample Completed - RNTester [x] Completed
Style – borderBottomRightRadius [x] Sample Completed - RNTester [x] Completed
Style – borderBottomStartRadius [ ] Not Completed [x] Completed
Style – borderBottomWidth [ ] Not Completed [x] Completed
Style – borderColor [x] Sample Completed - RNTester [x] Completed
Style – borderEndColor Not Implemented [x] Completed
Style – borderLeftColor Not Implemented [x] Completed
Style – borderLeftWidth [ ] Not Completed [x] Completed
Style – borderRadius [x] Sample Completed - RNTester [x] Completed
Style – borderRightColor Not Implemented [x] Completed
Style – borderStartColor Not Implemented [x] Completed
Style – borderStyle Not Implemented [x] Completed
Style – borderTopColor Not Implemented [x] Completed
Style – borderTopEndRadius [ ] Not Completed [x] Completed
Style – borderTopLeftRadius [x] Sample Completed - RNTester [x] Completed
Style – borderTopRightRadius [x] Sample Completed - RNTester [x] Completed
Style – borderTopStartRadius [ ] Not Completed [x] Completed
Style – borderTopWidth [ ] Not Completed [x] Completed
Style – borderWidth [x] Sample Completed - RNTester [x] Completed
Style – elevation Not Implemented [ ] Not Completed
Style – opacity [x] Sample Completed - RNTester [x] Completed
Style – height [x] Sample Completed - RNTester [x] Completed
Style –width [x] Sample Completed - RNTester [x] Completed
Style – overflow [ ] Not Completed [x] Completed
Style – backfaceVisibility [ ] Not Completed [x] Completed
Style – tintColor [x] Sample Completed - RNTester [x] Completed
Accessible [x] Sample Completed - RNTester [x] Completed
Focusable [ ] Not Completed [x] Completed
HitSlop [ ] Not Completed [x] Completed
NativeID [ ] Not Completed [x] Completed
NextFocus* [ ] Not Completed [ ] Not Completed
onAccessibilityAction [ ] Not Completed [x] Completed
onAccessibilityTab [ ] Not Completed [x] Completed
onAccessibilityEscape [ ] Not Completed [x] Completed
onLayout [ ] Not Completed [x] Completed
onMoveShoudlSetResponder [ ] Not Completed [x] Completed
onMoveShouldSetResponderCapture [ ] Not Completed [x] Completed
onResponderGrant [ ] Not Completed [x] Completed
onResponderMove [ ] Not Completed [x] Completed
onResponserReject [ ] Not Completed [x] Completed
onResponderRelease [ ] Not Completed [x] Completed
onResponderTerminate [ ] Not Completed [x] Completed
onResponderTerminationRequest [ ] Not Completed [x] Completed
onStartShouldSetResponder [ ] Not Completed [x] Completed
onStartShouldSetResponderCatpure [ ] Not Completed [x] Completed
pointerEvents [ ] Not Completed [x] Completed
removeClippedSubviews [ ] Not Completed [x] Completed
needsOffscreenAlphaCompositioning [ ] Not Completed [x] Completed
toolTip [ ] Not Completed [x] Completed
blurRadius [x] Sample Completed - RNTester [x] Completed
loadingIndicatorSource [x] Sample Completed - RNTester [x] Completed
onError [x] Sample Completed - RNTester [x] Completed
onLoad [x] Sample Completed - RNTester [x] Completed
onPartialLoad [x] Sample Completed - RNTester [x] Completed
onLoadEnd [x] Sample Completed - RNTester [x] Completed
onLoadStart [x] Sample Completed - RNTester [x] Completed
onProgress [x] Sample Completed - RNTester [x] Completed
resizeMode [x] Sample Completed - RNTester [x] Completed
Source [x] Sample Completed - RNTester [x] Completed
abortPrefecth() [ ] Not Completed [x] Completed
getSize() [x] Sample Completed - RNTester [x] Completed
getSizeWithHeaders() [ ] Not Completed [x] Completed
Prefetch() [x] Sample Completed - RNTester [x] Completed
queryCache() [x] Sample Completed - RNTester [x] Completed
resolveAssetSource() [ ] Not Completed [x] Completed

Contributor guide

Tech stack
javascripttypescriptreactjest
Domain
testingmobile
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JestReact NativeSnapshot testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine existing snapshot tests in RNTester (e.g., in `RNTester/js/components/`) to understand the pattern. For each prop marked 'Not Completed' under Paper, create a sample and snapshot test. Focus on props like `nextFocus*`, `removeClippedSubviews`, etc. Follow the format from completed tests. Use Jest's `toMatchSnapshot()` and ensure tests run on both Paper and Fabric architectures if applicable.