Microsoft/react-native-windows

Add E2E Snapshot Tests for Button

Open

#11198 opened on Feb 10, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (6,114 stars) (544 forks)batch import
Area: ButtonArea: FabricArea: TestsNew ArchitectureWorkstream: Test Coverageenhancementgood first issue

Description

Add E2E Jest Snapshot Tests for Button. Tests should exist as samples within RNTester.

STATUS TYPES

Status Description
Not Implemented Prop is not implemented for given architecture.
Not Completed No test or sample exists for the prop.
Sample Completed Sample exists for the prop, but sample is not run in a Jest Snapshot Test.
Completed Sample and Snapshot test exists for the prop.

PROPS STATUS FOR BUTTON

Test Description Status (Paper) Status (Fabric) Notes
Default Case [x] Completed – RNTester [x] Completed
AccessibilityLabel [x] Completed – RNTester [x] Completed
AccessibilityActions [ ] Not Completed [ ] Not Completed
AccessibilityRole [x] Completed – RNTester 10/22 Pass [x] Completed
AccessibilityHint [x] Completed – RNTester 10/22 Pass [x] Completed
AccessibilityState [x] Completed – RNTester [x] Completed
AccessibilityPosInSet [ ] Not Completed [x] Completed
AccessibilitySetSize [ ] Not Completed [x] Completed
AccessibilityValue [ ] Not Completed [x] Completed
AccessibilityLiveRegion [x] Completed – RNTester [x] Completed
onAccessibilityAction [ ] Not Completed [ ] Not Completed
onPress [x] Completed – RNTester [x] Completed
Color [x] Completed – RNTester [x] Completed
Disabled [x] Completed – RNTester [x] Completed
testID [x] Completed – RNTester [x] Completed
Style – elevation Not Implemented Not Implemented
Accessible [x] Completed – RNTester 10/22 Pass [x] Completed
Focusable [x] Completed – RNTester 10/22 Pass [x] Completed
NextFocus* Not Implemented Not Implemented

Contributor guide

Tech stack
javascriptreactjest
Domain
frontendtesting
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Jest snapshot testing basicsReact Native fundamentalsWindows development environment
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the RNTester app in the repository to locate existing Button examples. Identify which props are marked 'Not Completed' in the table. Write Jest snapshot test files similar to existing snapshot tests in the repository (e.g., in `packages/rn tester/js/examples/Button`). Ensure tests are added to the RNTester test suite and run correctly on both Paper and Fabric architecture if applicable. Check existing snapshot tests for patterns and ensure new tests follow the same conventions.