Microsoft/monaco-editor

Expose background color override for editorOverview

Open

#960 opened on Jul 17, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (14,836 stars) (1,283 forks)batch import
editor-corefeature-requesthelp wanted

Description

It seems strange that there is no way to change this one specific color. You basically can either use FFFFFF, 232323, or 000000 by way of changing the base theme from 'vs', 'vs-dark', and 'hc-black' respectively. Is there some technical blocker to exposing this color?

We are doing a fair bit of work in the theming department and it would be nice to be able to set this.

Contributor guide

Tech stack
javascripttypescript
Domain
frontenddesign
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic understanding of Monaco editor theming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the Monaco editor source code, specifically the theming system in the 'vs/editor/editor.main.js' or related TypeScript files. Look for how colors like 'editor.background' are defined and used. The issue requests exposing 'editorOverview' background color, which may be controlled by a separate theme property. Check if there's an existing theme token or if it's hardcoded. Review the 'monaco.editor.defineTheme' API documentation and examples to understand how to add new color overrides.