Microsoft/monaco-editor

[Bug] Since 0.46.0, dropped text append "$0"

Open

#4386 opened on Feb 16, 2024

View on GitHub
 (14 comments) (4 reactions) (1 assignee)JavaScript (14,836 stars) (1,283 forks)batch import
bughelp wanted

Description

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Link

https://microsoft.github.io/monaco-editor/playground.html?source=v0.46.0#example-creating-the-editor-hello-world

Monaco Editor Playground Code

Empty.

Reproduction Steps

  1. Open a notepad
  2. Type "text" in the notepad
  3. Drag and drop the text from the notepad to the editor on the playground

Actual (Problematic) Behavior

The editor contains "text$0".

Expected Behavior

The editor should contain "text".

Additional Context

I'm not sure, but I guess the problem must have appeared with this PR: https://github.com/microsoft/vscode/pull/202049 and come from this code: https://github.com/microsoft/vscode/blob/7f07489455fda8bc1841b98b9b7e58b20b7ee3ef/src/vs/editor/contrib/dropOrPasteInto/browser/edit.ts#L34

cc. @mjbvz

Contributor guide

Tech stack
javascripttypescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the drop/paste handling in monaco editor, specifically the file src/vs/editor/contrib/dropOrPasteInto/browser/edit.ts at line 34, as identified by the reporter. The suspected cause is linked to PR microsoft/vscode#202049. Read through the issue comments for any additional insights from maintainers or contributors about the root cause and possible fix.