Microsoft/monaco-editor

[Bug] Many duplicates in minified tsWorker.js leading to large file

Open

#4184 opened on Sep 22, 2023

View on GitHub
 (3 comments) (1 reaction) (0 assignees)JavaScript (14,836 stars) (1,283 forks)batch import
debthelp wanted

Description

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Reproduction Steps

  1. Open a compiled version of the file min/vs/language/typescript/tsWorker.min.js CDN Example
  2. Optionally copy the code in a VS Code window
  3. Search for interface CanvasDrawPath {
  4. Note that the definition is found twice
  5. This duplication issue is the case for a lot of code

Code20230923 - 0129

Actual (Problematic) Behavior

The minified version of tsWorker.js is around 4.6 MB I want to use the Monaco editor in a web extension, but this allows a maximum file size of 4 MB

If the code duplication is fixed, that would reduce the filesize enough to get below 4 MB

Expected Behavior

No duplicate code generated during the build

Additional Context

Related Add_ons Linter issue https://github.com/mozilla/addons-linter/issues/3915

Contributor guide

Tech stack
typescriptjavascript
Domain
performancebuild system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of build tools (webpack)Familiarity with minification
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the build configuration for tsWorker, likely in webpack config. Investigate how TypeScript lib declarations are bundled and minified, possibly causing duplication. Check if there's a deduplication plugin or if the build process can be adjusted to avoid including duplicate declarations. Refer to the related addons linter issue for context.