Microsoft/monaco-editor

[Bug] Cannot load `monaco-editor` esm module within Deno for bundling to the client.

Open

#3,501 opened on Jan 9, 2023

View on GitHub
 (3 comments) (2 reactions) (0 assignees)JavaScript (1,283 forks)batch import
feature-requesthelp wantedintegration

Repository metrics

Stars
 (14,836 stars)
PR merge metrics
 (Avg merge 6h 26m) (15 merged PRs in 30d)

Description

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Reproduction Steps

Can be reproduced by following the instructions on this example repo.

https://github.com/cowboyd/monaco-fresh#static-import

Actual (Problematic) Behavior

Just loading the monaco-editor module (not using it) fails because of this code https://github.com/microsoft/vscode/blob/12e6b0b3043f19d0cf1730eb3c213d3930310053/src/vs/base/browser/canIUse.ts#L21-L23

It appears that there has is specific carve out so that the code will run on NodeJS with the check for platform.isNative, but platform.isNative is false when running on Deno.

Expected Behavior

The ES module should be loaded successfully, even though you never call editor.create().

Contributor guide

Research direction
Inspect the `canIUse.ts` file and modify the platform check to also run under Deno, perhaps by checking for `globalThis.Deno` or extending the existing condition.
Tech stack
javascripttypescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScriptDeno
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60