Microsoft/monaco-editor

Lua syntax colorization not working properly [Bug]

Open

#3,444 opened on Dec 1, 2022

View on GitHub
 (0 comments) (2 reactions) (0 assignees)JavaScript (14,836 stars) (1,283 forks)batch import
bughelp wantedlanguages-basic

Description

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Code

monaco.editor.create(document.getElementById('container'), {
	value: "local string = \"Hello World\"\nlocal string_2 = [[Hello World]]\nlocal string_3 = [===[Hello World]===]",
	language: 'lua'
});

Reproduction Steps

Run the Monaco Editor playground code.

Actual (Problematic) Behavior

You will see "string_2" and "string_3" don't get string syntax colorization like in vscode.

Expected Behavior

Nested brackets string should have a syntax colorization like quotes.

Additional Context

No response

Contributor guide

Tech stack
javascripttypescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with Monaco Editorbasic understanding of TextMate grammars
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Look at the Lua language definition file (likely `src/languages/lua.js` or `src/basic languages/lua/lua.ts`) and the associated TextMate grammar. The issue is that nested brackets (e.g., `[[ ... ]]`, `[===[ ... ]===]`) are not highlighted as strings. Investigate how the grammar tokenizes these patterns and compare with VS Code's Lua grammar (which works). A fix may involve adding or adjusting the `patterns` array in the grammar to match multi bracket strings.
Lua syntax colorization not working properly [Bug] · Microsoft/monaco-editor#3444 | Good First Issue