Microsoft/monaco-editor

[Feature Request] enable retention of size of docs popup

Open

#2,999 opened on Feb 28, 2022

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (1,283 forks)batch import
feature-requesthelp wanted

Repository metrics

Stars
 (14,836 stars)
PR merge metrics
 (Avg merge 6h 26m) (15 merged PRs in 30d)

Description

Context

  • This issue is not a bug report. (please use a different template for reporting a bug)
  • This issue is not a duplicate of an existing issue. (please use the search to find existing issues)

Description

When the completions popup is resized, this new size is passed to IStorageService.store. Therefore theoretically it could be persisted to localStorage or some other persistent store (as per https://stackoverflow.com/questions/71293521/monaco-saving-preferences-to-localstorage).

However when the docs popup is resized, Monaco does not appear to save the new size:

Test in 0.31.1

Contributor guide

Research direction
Locate the code in Monaco editor that handles resizing of the docs popup and the storage service. Identify where the completions popup size is saved and apply similar logic to the docs popup.
Tech stack
javascripttypescript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60