Microsoft/monaco-editor

[Bug] Wrong highlight for shell

Open

#2,899 opened on Jan 19, 2022

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (1,283 forks)batch import
buggrammarshelp wanted

Repository metrics

Stars
 (14,836 stars)
PR merge metrics
 (Avg merge 6h 26m) (15 merged PRs in 30d)

Description

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Code

Do not use playground to try this. Using home page editor demo to try the following code.


if [[ -z "${MA5800_ALL_DIR:-}" ]]; then
    MA5800_ALL_DIR=$(realpath "$(dirname "$0")/../../")
fi

Actual Behavior

image

So I tried this code in vs-code, the highlight is correct.

image

Expected Behavior

My expected behavior is the highlight can as same as vs-code

Additional Context

No response

Contributor guide

Research direction
Investigate the shell grammar tokenizer in monaco editor; compare with VS Code's shell grammar to find the discrepancy.
Tech stack
javascripttypescript
Domain
frontenddeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gitmonaco editor build setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60