Microsoft/monaco-editor

[Feature Request] Add suuport for php8 attributes

Open

#2,898 opened on Jan 18, 2022

View on GitHub
 (2 comments) (2 reactions) (0 assignees)JavaScript (1,283 forks)batch import
feature-requestgrammarshelp wanted

Repository metrics

Stars
 (14,836 stars)
PR merge metrics
 (Avg merge 6h 26m) (15 merged PRs in 30d)

Description

Context

  • This issue is not a bug report. (please use a different template for reporting a bug)
  • This issue is not a duplicate of an existing issue. (please use the search to find existing issues)

Description

In the php 8 there is a new mechanism, which is attributes. However, in editor, they look like comments. E.g.

#[Attr(...), Attr(...)]
private int $a;

image

In single lines it can be skipped, but attributes can be multilines, what makes it totally wrongly colored. E.g.

#[ArrayShape([
	'id' => 'int',
	'month' => 'int',
	'day' => 'int',
	'usual' => 'int'
])]

image

Contributor guide

Research direction
Locate the PHP syntax highlighting grammar file in Monaco (e.g., the TextMate JSON or TypeScript grammar). Add tokenizer rules to recognize PHP 8 attribute syntax `#[...]` as a distinct token type, ensuring multiline support. Update the theme if needed to highlight attributes differently from comments.
Tech stack
javascripttypescriptphp
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPTextMate grammars
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65