Microsoft/monaco-editor

Rust syntax highlighting broken for raw strings

Open

#2,897 opened on Jan 17, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,283 forks)batch import
buggrammarshelp wanted

Repository metrics

Stars
 (14,836 stars)
PR merge metrics
 (Avg merge 6h 26m) (15 merged PRs in 30d)

Description

Seems like this is still a problem for code such as:

fn main() {
    let a = r#"hello" world"#;
    println!("{}", a);
}

Using the #ed raw strings. Now that the rust-playground may also use monaco one may encounter this problem:

image

Note: rust's raw strings are formed as an r, then some number of #s, "<the string here>", then a matching number of #s

Originally posted by @Ben-Lichtman in https://github.com/microsoft/monaco-editor/issues/2552#issuecomment-1013553336

Contributor guide

Research direction
Investigate the Rust syntax tokenizer in the Monaco editor's Monarch or TextMate grammar, focusing on raw string literals with `r#` and `#` sequences.
Tech stack
typescriptjavascriptrust
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70