Microsoft/monaco-editor

Wrong YAML syntax highlighting

Open

#2,681 opened on Oct 4, 2021

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (1,283 forks)batch import
buggrammarshelp wanted

Repository metrics

Stars
 (14,836 stars)
PR merge metrics
 (Avg merge 6h 26m) (15 merged PRs in 30d)

Description

There seem to be some wrong syntax highlighting when for example entering foo: "{bar: 7}". Monaco highlights {bar the same way as foo. It should better respect that it is part of a string value. Just tested the same with VS Code and it doesn't have this problem.

monaco-editor version: 0.28.0 Browser: tested in Chrome OS: Windows 10 Playground code that reproduces the issue:

monaco.editor.create(document.getElementById("container"), {
    value: 'foo: "{bar: 7}"\n',
    language: 'yaml'
});

Contributor guide

Research direction
Examine the YAML tokenizer in Monaco's source, specifically how string values with nested braces are tokenized. Compare with VS Code's handling to identify the difference.
Tech stack
typescriptjavascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70