Microsoft/monaco-editor

JavaScript syntax highlighting misidentifies `get` as a reserved keyword

Open

#2,676 opened on Sep 29, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,283 forks)batch import
buggrammarshelp wanted

Repository metrics

Stars
 (14,836 stars)
PR merge metrics
 (Avg merge 6h 26m) (15 merged PRs in 30d)

Description

https://microsoft.github.io/monaco-editor/ image

Within Javascript files, the word "get" is highlighted as a reserved word when it shouldn't.

Browser: Checked on Chrome, Mozilla Firefox and MS Edge

import get from 'lodash/get';
const id = get(param1, param2);

Contributor guide

Research direction
Inspect the JavaScript grammar file used by Monaco Editor for syntax highlighting, find the tokenizer rule that marks 'get' as a reserved word, and adjust it to only highlight 'get' when used as a property accessor (e.g., `get name()`) not as a function name.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptUnderstanding of textmate grammars
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75