Microsoft/monaco-editor

Syntax Highlighting isn't working for the first item inside a Media Query

Open

#2,527 opened on Jun 14, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,283 forks)batch import
buggrammarshelp wanted

Repository metrics

Stars
 (14,836 stars)
PR merge metrics
 (Avg merge 6h 26m) (15 merged PRs in 30d)

Description

monaco-editor version: 0.25.0 Browser: Chrome 91.0.4472.77 (but appearing in all browsers tested in) OS: MacOS 11.4 Playground code that reproduces the issue:

@media (max-width: 300px) {
    p.test {

    }

    p.test {
        
    }
}

You'll see that the first p.test selector does not have syntax highlighting, where the second does.

Note that this isn't reproducible in VS Code directly, nor in VS Code web. It is however visible on the Monaco Editor homepage if you change the language to CSS and scroll down to line 629.

Contributor guide

Research direction
Investigate the CSS syntax tokenizer in Monaco Editor to identify why the first rule inside a @media block lacks syntax highlighting. Focus on the TextMate grammar or custom tokenizer for CSS.
Tech stack
typescriptcss
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CSSTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50